Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some minor annoyances #3842

Merged
merged 3 commits into from
Feb 27, 2024
Merged

fix some minor annoyances #3842

merged 3 commits into from
Feb 27, 2024

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Feb 27, 2024

Description

  • Renamed "testing" to "show plot" which is a more obvious name for the user facing API
  • Fixed voltage limits check, matching limits exactly should be allowed

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman
Copy link
Contributor

kratman commented Feb 27, 2024

Codecov failure is unrelated, since it is failing on other PRs

@valentinsulzer valentinsulzer merged commit 3fc9594 into develop Feb 27, 2024
43 of 45 checks passed
@valentinsulzer valentinsulzer deleted the fix-minor-bugs branch February 27, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants