-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Degradation example update #3691
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good. You have some really old commits on this branch though. The other PR you closed was from your develop branch and did the same thing. My guess is that you should reset your develop branch to the main pybamm develop branch
Also you have some reverts, so it might be best to squash this PR to a single commit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3691 +/- ##
========================================
Coverage 99.59% 99.59%
========================================
Files 258 258
Lines 20796 20796
========================================
Hits 20711 20711
Misses 85 85 ☔ View full report in Codecov by Sentry. |
The experiment protocol for the coupled degradation example notebook was changed so that the 5 minute period applied to all stepts of all cycles, including the 1C discharge. This results in the simulation being unstable for large numbers of cycles. This pull request reverts the change and fixes the issue.
Fixes #3669
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.