Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python-idaklu #4223

Closed
martinjrobins opened this issue Jun 27, 2024 · 3 comments · Fixed by #4326
Closed

remove python-idaklu #4223

martinjrobins opened this issue Jun 27, 2024 · 3 comments · Fixed by #4326
Assignees
Labels
feature refactor refactoring existing code solver

Comments

@martinjrobins
Copy link
Contributor

Description

The python-idaklu solver is a legacy solver that uses idaklu but calls back into python for the functions. With the recent improvements to idaklu this can now be removed.

Motivation

reduce the number of solvers we need to maintain

Possible Implementation

No response

Additional context

No response

@martinjrobins martinjrobins added feature solver refactor refactoring existing code labels Jun 27, 2024
@kratman
Copy link
Contributor

kratman commented Jun 28, 2024

@martinjrobins It would be nice to break out idaklu into its own package within the PyBaMM ecosystem. That would let PyBaMM just install it as a library similar to how we install a casadi package. Is it feasible to do that along with removing the old solver?

@agriyakhetarpal
Copy link
Member

It would be nice to break out idaklu into its own package within the PyBaMM ecosystem

Note for other readers: this was discussed in the monthly developer meeting in April and in the recent v24.5 release prep meeting. @Saransh-cpp reported that this could be a suitable 175-hour GSoC project

@rtimms
Copy link
Contributor

rtimms commented Jul 6, 2024

@MarcBerliner not sure if you've seen this but I know you were looking at IDAKLU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature refactor refactoring existing code solver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants