-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Roadmap area] Parameter refactor #3909
Comments
FYI we (Ionworks) have a FUSE internship open for applications that is related to this, so we can support this over the summer |
I think the main points to discuss are:
|
Also, when we do this, it would be great to do a deep review of existing parameter sets, including removing parameters that are not provided in the original reference (e.g SEI parameters for a performance-only model). See #3919 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Refactor parameter values to use the BPX format by default.
Using nested dictionaries allows cleaner definition of negative / positive and also different components of the battery.
This is a big breaking change so we should add a conversion class from legacy parameter sets to new ones, and legacy parameter sets should still work for a while.
Originally posted by @tinosulzer in #3839 (comment)
The text was updated successfully, but these errors were encountered: