Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: pouch models fail with voltage or power control #3828

Closed
rtimms opened this issue Feb 19, 2024 · 0 comments · Fixed by #3829
Closed

[Bug]: pouch models fail with voltage or power control #3828

rtimms opened this issue Feb 19, 2024 · 0 comments · Fixed by #3829
Labels
bug Something isn't working

Comments

@rtimms
Copy link
Contributor

rtimms commented Feb 19, 2024

PyBaMM Version

24.1

Python Version

3.11

Describe the bug

Pouch cell simulations with voltage or power control fail with the error

TypeError: Initial conditions cannot contain 'Variable' objects, but 'Variable(-0x4b072f39e284004e, Current variable [A], children=[], domains={})' found in initial conditions for 'Current collector current density [A.m-2]'

Steps to Reproduce

import pybamm

model = pybamm.lithium_ion.DFN(
    {
    "cell geometry": "pouch",
    "current collector": "potential pair",
    "dimensionality": 1,
    "thermal": "x-lumped"
    },
)


experiment = pybamm.Experiment(["Hold at 4.2 V until C/20 (5 seconds period)"])
sim = pybamm.Simulation(model, experiment = experiment)
sol = sim.solve()

Relevant log output

No response

@rtimms rtimms added the bug Something isn't working label Feb 19, 2024
rtimms added a commit that referenced this issue Feb 19, 2024
rtimms added a commit that referenced this issue Feb 19, 2024
rtimms added a commit that referenced this issue Feb 21, 2024
* #3828 fix pouch cell voltage control

* #3828 changelog
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant