Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from conda to venv inside Docker Images #3692

Closed
arjxn-py opened this issue Jan 6, 2024 · 6 comments · Fixed by #3901
Closed

Migrate from conda to venv inside Docker Images #3692

arjxn-py opened this issue Jan 6, 2024 · 6 comments · Fixed by #3901
Assignees
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows

Comments

@arjxn-py
Copy link
Member

arjxn-py commented Jan 6, 2024

This would potentially cut down an external system dependency conda & would reduce the inconsistency of environments across different OS for IDAKLU solver images.

@arjxn-py arjxn-py added difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows labels Jan 6, 2024
@arjxn-py
Copy link
Member Author

arjxn-py commented Jan 6, 2024

Labelling it easy at the moment but since the base image would be changed as well, the complexity might reach medium as well.

@agriyakhetarpal
Copy link
Member

It might reach medium, the newer choice of base image should be GLIBC compliant. If it's possible, we can use the checked out files from the repository to build the image instead of cloning PyBaMM inside it.

@agriyakhetarpal
Copy link
Member

I was thinking of taking this up if you don't mind that, @arjxn-py – I have been been wanting to learn more things about Docker recently

@arjxn-py
Copy link
Member Author

Yes, why not. Feel free to take this up 💯

@santacodes
Copy link
Contributor

Can I take this issue if it's not being worked on by any chance?

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Feb 25, 2024

Sure, @santacodes – I won't be able to work on this realistically anytime soon, feel free to take this up. Some guidelines are:

  1. We need this image for both amd64 and aarch64 platforms.
  2. The image needs to be compliant with the PEP599 manylinux2014 platform tag, i.e., the same one as what we publish PyPI wheels for – please view the document here: https://peps.python.org/pep-0599/. This means that it should rely on a GLIBC version no later than 2.17.
  3. We should target Reduce the number of Docker Images to just one image #3666 to reduce the number of images and include one image with the latest tag with all solvers (the current pybamm/pybamm:latest image includes no compiled solvers). Feel free to close both issues in one PR in order to reduce merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows
Projects
None yet
3 participants