Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise caches for Windows nightly tests and test wheels weekly instead of fortnightly #3664

Closed
agriyakhetarpal opened this issue Dec 25, 2023 · 4 comments
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve

Comments

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Dec 25, 2023

The scheduled tests (unit, integration, examples) are run in a CRON job overnight for all platforms, but they don't compile the IDAKLU solver for Windows. We don't do it in PR tests to save time, but it should be reasonable to do so for the nightly tests – I have noticed that it takes around 15 minutes to compile the build-time dependencies on Windows, and less than three minutes if a vcpkg cache hit occurs. Allowing this cache to be set for the nightly tests on an ephemeral system like this would make sure that it will remain available for further tests and when one tries to debug the wheels or publish them, and thereby ensure that the jobs remain speedy. The cache can be invalidated by any changes to the vcpkg configuration files anyway so it is ensured that stale caches will never be used.

Building wheels weekly instead of fortnightly ensures that the set cache can be retained for further use in different scenarios, since GitHub Actions caches are evicted after a duration of one week.

@agriyakhetarpal agriyakhetarpal added difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve labels Dec 25, 2023
@agriyakhetarpal agriyakhetarpal changed the title Utilise caches for Windows nightly tests and test wheels weekly instead of fortnightly Utilise caches for Windows nightly tests and test wheels weekly instead of fortnightly Dec 25, 2023
@R-Yash
Copy link
Contributor

R-Yash commented Jan 31, 2024

@agriyakhetarpal I want to work on this issue. I am thinking of modifying the run_periodic_tests.yaml by adding a step to cache vkpg dependencies and changing the tests to weekly in publish_pypi.yml. Is this the correct approach?

@agriyakhetarpal
Copy link
Member Author

Yes, that's right. I shall assign you this issue; please feel free to seek any more information as you need it.

@R-Yash
Copy link
Contributor

R-Yash commented Jan 31, 2024

Thanks @agriyakhetarpal

@agriyakhetarpal
Copy link
Member Author

Closing because it's most likely not needed at this time (testing every two weeks is fine, caches are not needed for nightly Windows tests right now); can be re-opened sometime later.

@agriyakhetarpal agriyakhetarpal closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants