Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jax now supports mac with m1 chip #1775

Closed
priyanshuone6 opened this issue Nov 2, 2021 · 3 comments · Fixed by #1767
Closed

Jax now supports mac with m1 chip #1775

priyanshuone6 opened this issue Nov 2, 2021 · 3 comments · Fixed by #1767

Comments

@priyanshuone6
Copy link
Member

No description provided.

@valentinsulzer
Copy link
Member

Good to know, thanks :) Is there an action you suggest with this? Since we're making jax optional anyway?

@priyanshuone6
Copy link
Member Author

We should undo this 12cca81 or should I remove all of it?

@valentinsulzer
Copy link
Member

I think instead of being based on the platform, the testing of those lines should depend on whether the user has installed jax or not

@priyanshuone6 priyanshuone6 mentioned this issue Nov 3, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make jax optional priyanshuone6/PyBaMM
2 participants
@valentinsulzer @priyanshuone6