From 3ec4f82c66648cb31439f6f1738555ff96293cb6 Mon Sep 17 00:00:00 2001 From: "jiabin.wang" Date: Fri, 5 Apr 2024 15:57:05 +0100 Subject: [PATCH 1/2] update base_solver.step --- pybamm/solvers/base_solver.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pybamm/solvers/base_solver.py b/pybamm/solvers/base_solver.py index fb4865358d..48aa19d491 100644 --- a/pybamm/solvers/base_solver.py +++ b/pybamm/solvers/base_solver.py @@ -1117,9 +1117,8 @@ def step( npts : deprecated inputs : dict, optional Any input parameters to pass to the model when solving - save : bool - Turn on to store the solution of all previous timesteps - + save : bool, optional + Save solution with all previous timesteps. Defaults to True. Raises ------ :class:`pybamm.ModelError` From bac929455e2cac172f3e086f13bc26b96ea99920 Mon Sep 17 00:00:00 2001 From: "jiabin.wang" Date: Fri, 5 Apr 2024 15:59:11 +0100 Subject: [PATCH 2/2] update base_solver.solve --- pybamm/solvers/base_solver.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pybamm/solvers/base_solver.py b/pybamm/solvers/base_solver.py index 48aa19d491..82d6159769 100644 --- a/pybamm/solvers/base_solver.py +++ b/pybamm/solvers/base_solver.py @@ -710,16 +710,16 @@ def solve( The model whose solution to calculate. Must have attributes rhs and initial_conditions. All calls to solve must pass in the same model or an error is raised - t_eval : numeric type - The times (in seconds) at which to compute the solution + t_eval : None, list or ndarray, optional + The times (in seconds) at which to compute the solution. Defaults to None. inputs : dict or list, optional A dictionary or list of dictionaries describing any input parameters to pass to the model when solving nproc : int, optional Number of processes to use when solving for more than one set of input parameters. Defaults to value returned by "os.cpu_count()". - calculate_sensitivities : list of str or bool - If true, solver calculates sensitivities of all input parameters. + calculate_sensitivities : list of str or bool, optional + Whether the solver calculates sensitivities of all input parameters. Defaults to False. If only a subset of sensitivities are required, can also pass a list of input parameter names