Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PyBaMM's create_gif function and remove BattBot's create_gif function #83

Closed
Saransh-cpp opened this issue Oct 26, 2021 · 0 comments · Fixed by #88
Closed

Use PyBaMM's create_gif function and remove BattBot's create_gif function #83

Saransh-cpp opened this issue Oct 26, 2021 · 0 comments · Fixed by #88
Labels

Comments

@Saransh-cpp
Copy link
Member

Now that #1754 is merged, the bot can do something like this -

batch_study.create_gif()

instead of -

create_gif(batch_study)

This can also be changed here -

create_gif(batch_study, labels=labels)

The create_gif function and the tests can also be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant