-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: more specific community partners page with FAQ #253
Conversation
hi friends - would love some review from some of our partners here! @pllim @jibarnum @mikelkou can you please have a look here and share this with anyone who may be interested in reading our general overview / policy page on what peer review partnerships look like? i'm trying to capture all of the discussions, questions etc that we've collectively had into a single document that can be useful to everyone. many thanks |
Thanks for the ping. I'll put this on my queue. I am also pinging Astropy editors, @dhomeier and @WilliamJamieson. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think overall this is consistent with what Astropy is thinking over at astropy/astropy-APEs#87 . I will cross-link this PR over there.
Just some minor comments/questions.
partners/scientific-communities.md
Outdated
@@ -1,4 +1,4 @@ | |||
# pyOpenSci Software Peer Review Partnerships | |||
# Scientific Python Partnerships |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scientific Python here means https://scientific-python.org/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh no i mean as in we partner with scientific Python communities such as astropy. so lower case "s" rather than the project. maybe i could write:
Partnerships with Scientific Python communities?
would that be more clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. If I didn't know what is "Scientific Python" and I search that term on the Internet, I would still think it is that other org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i follow. so perhaps just
pyOpenSci Community Peer Review Partnerships - closer to how it was initially is best?
partners/scientific-communities.md
Outdated
|
||
**Coming in 2024** | ||
|
||
1. Access to metric dashboards for all accepted packages in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numbered list does not quite make sense here unless you plan to add more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. i'll edit that locally. we also will be implementing a review bot.
Not sure what is going on in the CI.
|
I will look into that! the google doc links need to be removed and the 2i2c page - perhaps it has moved. i'll look into this and fix things while also merging your suggestions and cleaning up text!! thanks so much for the review here. |
Co-authored-by: P. L. Lim <[email protected]>
Co-authored-by: P. L. Lim <[email protected]>
Co-authored-by: P. L. Lim <[email protected]>
Co-authored-by: P. L. Lim <[email protected]>
Revising the capitalisation and hypthenation for the EIC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together!
Co-authored-by: Gregor Sturm <[email protected]>
@all-contributors please add @pllim for code, review |
@all-contributors please add @grst for code, review |
I've put up a pull request to add @grst! 🎉 |
Hi everyone 👋 i think i've largely addressed all of the comments here (thank you for the input here!). this PR has been open since September 18. let's plan to merge it by next Monday October 30th. Please leave any last comments in prior to then. NOTE: our entire peer review guide is seen as a living document that can be changed over time as we grow and recognize other issues. Thus, please know you can also review the live page and open issues if you see missing / incorrect / confusing information after monday the 30th of october! Also please have a look at our website new partner page . Once we formalized partnerships i'll be sure to include a list of partners with your logos and then links to each partners page on our website. but for now it contains an overview of what a partnership looks like. |
ok colleagues! i've addressed (i believe) all of the comments in this pull request! i am going to merge this document. BUT if you catch issues with it after it has gone online, please just open a new ISSUE in this repo and we can address it together. This is a living document that will evolve over time as we build our partnership together and learn about challenges and needs! thank you all for the help in bringing this process together! |
This is a new partners page that addresses all of the questions that I feel like i've been answering! I may have missed some so welcome any and all reviews from folks.