DEP: Remove deprecated code #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinThoma
force-pushed
the
deprecations
branch
from
d22c6cc
to
7e4ba42
Compare
MartinThoma
changed the title
|
I need to check if the |
MartinThoma
force-pushed
the
deprecations
branch
from
7e4ba42
to
0827dd5
Compare
Also don't use a default for the deprecation functions. If the version is mentioned explicitly with every call, we can more easily search for it.
MartinThoma
force-pushed
the
deprecations
branch
from
0827dd5
to
3d45f24
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2367 +/- ##
==========================================
- Coverage 94.54% 94.45% -0.09%
==========================================
Files 43 43
Lines 7549 7575 +26
Branches 1490 1515 +25
==========================================
+ Hits 7137 7155 +18
- Misses 253 257 +4
- Partials 159 163 +4 ☔ View full report in Codecov by Sentry. |
MartinThoma
force-pushed
the
deprecations
branch
2 times, most recently
from
7f577d9
to
eb630aa
Compare
MartinThoma
force-pushed
the
deprecations
branch
3 times, most recently
from
64002d6
to
f2fd7b8
Compare
MartinThoma
force-pushed
the
deprecations
branch
from
f2fd7b8
to
8665b27
Compare
MartinThoma
force-pushed
the
deprecations
branch
from
164ea8d
to
32f6e5a
Compare
MartinThoma
force-pushed
the
deprecations
branch
from
32f6e5a
to
8263e1e
Compare
MartinThoma
added a commit
that referenced
this pull request
Jan 19, 2024
## What's new pypdf==4.0.0 is a big milestone forward: * We finally have a layout-mode text extraction. This enables users who want to detect / extract tables with heuristics to give it a try. * We deprecated a lot of the old PyPDF2 API that was either not following PEP8 naming styles or was not using a property. Users comming from PyPDF2 might want to switch first to pypdf<4.0.0 to get helpful error messages that show the new API in their speicific cases. A big 'Thank you!' the the whole pypdf community for your work. Thanks to you, pypdf is better than ever. Kudos to @shartzog who added the layout-mode with his first contribution! ### Deprecations (DEP) - Drop Python 3.6 support (#2369) by @MartinThoma - Remove deprecated code (#2367) by @MartinThoma - Remove deprecated XMP properties (#2386) by @stefan6419846 ### New Features (ENH) - Add "layout" mode for text extraction (#2388) by @shartzog - Add Jupyter Notebook integration for PdfReader (#2375) by @MartinThoma - Improve/rewrite PDF permission retrieval (#2400) by @stefan6419846 ### Bug Fixes (BUG) - PdfWriter.add_uri was setting the wrong type (#2406) by @pmiller66 - Add support for GBK2K cmaps (#2385) by @stefan6419846 ### Documentation (DOC) - Add pmiller66 for #2406 as a contributor by @MartinThoma - Add missing expand parameter (#2393) by @Atomnp - Resolve build warnings (#2380) by @stefan6419846 - Fix testing prerequisites (#2381) by @stefan6419846 - Improve formatting of contributors page (#2383) by @stefan6419846 - Add Tobeabellwether as a contributor for #2341 by @MartinThoma ### Developer Experience (DEV) - Make dependabot aware of our PR prefixes (#2415) by @stefan6419846 - Fail on Sphinx issues (#2405) by @stefan6419846 - Move title check to own workflow (#2384) by @MasterOdin - Write to temporary files instead of the working directory (#2379) by @stefan6419846 - Ensure that the PR titles have the correct format (#2378) by @stefan6419846 ### Maintenance (MAINT) - Complete FileSpecificationDictionaryEntries constants (#2416) by @MartinThoma - Return None instead of -1 when page is not attached (#2376) by @MartinThoma - Replace warning with logging.error (#2377) by @MartinThoma ### Testing (TST) - Add missing pytest.mark.samples annotations (#2412) by @kitterma - Correctly close temporary files (#2396) by @stefan6419846 - Fix side effect #2379 (#2395) by @pubpub-zz - Add test for layout extraction mode (#2390) by @MartinThoma ### Code Style (STY) - Use the UserAccessPermissions enum (#2398) by @MartinThoma - Run black (#2370) by @MartinThoma [Full Changelog](3.17.4...4.0.0)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't use a default for the deprecation functions. If the version is mentioned explicitly with every call, we can more easily search for it.
Consistent terminology for outline items(MAINT: Consistent terminology for outline items #1156, pypdf==2.9.0) introduced it. Meaning in pypdf==4.0.0 we can remove them 🎉