Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix nested /DeviceN color space #2241

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

stefan6419846
Copy link
Collaborator

@stefan6419846 stefan6419846 commented Oct 5, 2023

This adds handling for nested color spaces for the /DeviceN color space.

Fixes #2240

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (30db3ef) 94.36% compared to head (a0a0950) 94.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2241   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files          43       43           
  Lines        7591     7593    +2     
  Branches     1498     1498           
=======================================
+ Hits         7163     7165    +2     
  Misses        264      264           
  Partials      164      164           
Files Coverage Δ
pypdf/_xobj_image_helpers.py 91.97% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinThoma MartinThoma merged commit e628555 into py-pdf:main Oct 7, 2023
14 checks passed
@MartinThoma
Copy link
Member

Thank you 🤗

@stefan6419846 stefan6419846 deleted the nested_devicen_colorspace branch October 7, 2023 19:09
MartinThoma added a commit that referenced this pull request Oct 8, 2023
## What's new

### Bug Fixes (BUG)
-  invalid cm/tm in visitor functions (#2206) by @pubpub-zz
-  Encrypt / decrypt Stream object dictionaries (#2228) by @pilotandy
-  Support nested color spaces for the /DeviceN color space (#2241) by @Stefan
-  images property fails if NullObject in list (#2215) by @pubpub-zz

### Robustness (ROB)
-  XYZ destination to cope with missing left and top param (#2237) by @pubpub-zz

### Documentation (DOC)
-  Add pilotandy for #2228 as a contributor by @MartinThoma
-  Link to CONTRIBUTING.md in README.md (#2232) by @markpfeifle
-  Changelog by @MartinThoma

### Developer Experience (DEV)
-  Exclude tests from mypy checks by @MartinThoma
-  Unify mypy options and warn redundant workarounds (#2223) by @exiledkingcc
-  Stabilize Pillow test with Pillow missing (#2229) by @Stefan

### Maintenance (MAINT)
-  Update pinned packages (#2243) by @MartinThoma

### Testing (TST)
-  Regression test against non-deterministic accidental object reuse (#2244) by @MartinThoma

[Full Changelog](3.16.2...3.16.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unhashable type 'ArrayObject'" when extracting images with nested color space definition
2 participants