Update and unpin some dependencies #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkjt2000
approved these changes
May 24, 2023
|
I did not take time to investigate the linter error from pyright, but the dependencies look good. |
I already fix those in a2d5531, so I will just cherry-pick the commit. |
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our dependencies in
maingroup were pinned since adding the poetry (which means - they were pinned always). This is a bad practice because it doesn't allow the user to install any other version of the used by us library.I also hope that bumping
coveragedependency will fix flaky Windows tests that are pretty randomly crash withAttributeError: 'NoneType' object has no attribute 'startswith'(it points to coverage.py files).I also didn't update tox to v4 because of two reasons:
tox-poetrywas deprecated and there is no stable version that supports v4. (Deprecation because Poetry included official support of tox)I personally have no motivation to fix these issues and I would better go with #488 as solution for those.
Python version was bumped from
3.8.0+to3.8.1+because of similar bump inflake8-bugbear.