-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcstatus cli: Motd is not JSON serializable #825
Comments
Yeah, this is caused by #335 which rewritten how Motd is stored. There are multiple ways we could handle this due to how we represent motd now. The easiest way to resolve this would be to just use The other option would be to customize the serialization to work with how the motd is represented by us in code now. This might be a bit nicer to work with for people, but is a breaking change. If we would want to go with the representation that follows our custom motd parser, we will also need to decide on how it should look in json. All we'd need is to represent the I think it's enough to just go with the simple fix of using the raw data. |
CC @PerchunPak You opinion? |
For now, it is easier to just use Though I am curious how much CLI is used, and I guess if it was broken for a year, it is not used by almost anyone, so I would like to remove it. It is hard to represent current internal objects with JSON. |
Not sure how much more there is to write about this, issue should be clear from the output.
Output:
The text was updated successfully, but these errors were encountered: