Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md documentation link open blank docs page #534

Closed
TiEmKej opened this issue May 6, 2023 · 10 comments
Closed

README.md documentation link open blank docs page #534

TiEmKej opened this issue May 6, 2023 · 10 comments
Labels
area: documentation Related to project's documentation (comments, docstrings, docs)

Comments

@TiEmKej
Copy link

TiEmKej commented May 6, 2023

Would you change the link to "lastest" branch of docs, so readers wouldn't have to change it manually?

@PerchunPak
Copy link
Member

There are no docs for v10 because they were added in unreleased v11. And we can't use docs from v11 for v10 because v11 changed public interfaces a lot (see #306 and #335).

Although, if you want to try new features - just use release candidate, it's pretty stable!

pip install mcstatus>=11.0.0rc1

Not closing this, because we probably should add some warning to stable tag.

@kevinkjt2000
Copy link
Contributor

Nope, not changing the readme link because people kept coming into our Discord server saying that the "latest" docs were not matching up with the newest stable version which they thought was "latest".

A warning/disclaimer on stable for a short while wouldn't hurt. Another idea would be to rename "latest" on readthedocs to something like "pre-release" or "testing" to make it obvious that it is part of development still.

@kevinkjt2000 kevinkjt2000 added the area: documentation Related to project's documentation (comments, docstrings, docs) label May 6, 2023
@PerchunPak
Copy link
Member

PerchunPak commented May 7, 2023

A warning/disclaimer on stable for a short while wouldn't hurt. Another idea would be to rename "latest" on readthedocs to something like "pre-release" or "testing" to make it obvious that it is part of development still.

Or just add another tag.

@kevinkjt2000
Copy link
Contributor

What I was driving at is that "latest" is not a very descriptive label. Latest of what? stable? beta? from development? release on PyPi? I'd say that most people would assume "latest" corresponds with the latest released version and not realize that there are some pre-releases out at the moment since pip defaults to not installing pre-releases.

Of course once v11 is out, this naming scheme on readthedocs would matter less.

@PerchunPak
Copy link
Member

Then, we can rename latest to development or master.

@ItsDrike
Copy link
Member

ItsDrike commented May 8, 2023

Once v11 is out, the naming indeed wouldn't matter that much, and latest isn't that bad label when shown next to stable, most python documentation sites use these, so it's usually obvious what they are, but I wouldn't mind a rename to development if possible.

@kevinkjt2000
Copy link
Contributor

Okay, I've made a temporary preview of what v10 docs could look like on this branch https://mcstatus.readthedocs.io/en/docs-on-v10/

If these are looking okay for v10, then I'll release a v10.0.4 version to promote these into "stable" on readthedocs. With plans to null-merge all of this into master via the backports branch that I also pushed, since many of these files have had significant changes in v11.

@ItsDrike
Copy link
Member

ItsDrike commented May 8, 2023

The advanced usage shows mcproto.dns functions, which we determined weren't a part of the public API, and so they were removed later, they probably shouldn't be there. The entire advanced usage section can be removed, and the dns docs should be moved under internal data. You can probably cherry pick that off of some Perchunk Pak's commit, as I already requested this change in some PR before (though it might've been fixed via a force push instead, potentially making cherry picking hard).

@PerchunPak
Copy link
Member

19e2446

@ItsDrike ItsDrike mentioned this issue May 13, 2023
@kevinkjt2000
Copy link
Contributor

Can close this now that v11 is out with all the doc changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Related to project's documentation (comments, docstrings, docs)
Projects
None yet
Development

No branches or pull requests

4 participants