Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feols and fepois` check input types for literal string arguments #691

Open
marcandre259 opened this issue Nov 2, 2024 · 2 comments
Open

feols and fepois` check input types for literal string arguments #691

marcandre259 opened this issue Nov 2, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@marcandre259
Copy link
Contributor 

          Another thing I oversaw in my initial review - `feols` and `fepois` check input types in https://github.com/py-econometrics/pyfixest/blob/a3ed27aefef01e80ade7ebf117d5999239bbb62b/pyfixest/estimation/estimation.py#L617

Maybe we could update them to use the Literal validation function whenever relevant?

Originally posted by @s3alfisc in #680 (comment)
@marcandre259 marcandre259 changed the title Another thing I oversaw in my initial review - feols and fepois check input types in https://github.com/py-econometrics/pyfixest/blob/a3ed27aefef01e80ade7ebf117d5999239bbb62b/pyfixest/estimation/estimation.py#L617 feols and fepois` check input types for literal string arguments Nov 2, 2024
@s3alfisc
Copy link
Member

s3alfisc commented Nov 2, 2024

Yes, would be nice to do it via validate_literals!

@marcandre259
Copy link
Contributor Author

Super, I'll look into it :)

@s3alfisc s3alfisc added the enhancement New feature or request label Nov 2, 2024
@marcandre259 marcandre259 removed their assignment Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s3alfisc @marcandre259