-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logistic Regression #668
Comments
Definitely of interest to me and I also like the idea of a separate GLM class. However, I'll first focus on updating the |
Cool! I might try myself at a very basic implementation over the weekend =) |
Conditional v Unconditional choice should be informed by whether you want to support the computation of partial effects, right? CL has a really clean, simple solution that will likely scale a lot faster than the unconditional logit from the OP [they have an R package too btw]. |
I was thinking about implementing the Additionally, this is what The other main advantage (if you want to call it one) is that it's an IWLS algorithm similar to Generally, I think the main advantage of having a logit class is that we could use it to compute propensity scores without having to add outside dependencies (which in turn would then allow to implement doubly robust estimators). I'm actually not sure how many users would be interested in using it directly to compute partial effects, though I think at least in teaching, some might want to? @aeturrell or @gbekes might have opinions on this? =) ![image](https://github.com/user-attachments/assets/3127a8b8-2202-4f19-99c6-d879323b77cb |
Tagging @vincentarelbundock for marginal effects |
Would be cool to support logistic regression, so we could implement the unconditional logit estimator described in Stamann et al:
.
The function could inherit or just borrow much from the Fepois class as it also implements a iterated weighted least squares estimator with demeaning steps in every iteration.
Alternatively, we could also set up a GLM base class, from which both Fepois and Felogit could inherit - but rather something for a second refactoring PR and maybe overkill.
Maybe of interest for @leostimpfle or @Jayhyung ? =)
The text was updated successfully, but these errors were encountered: