Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Organize CI Tests #623

Closed
s3alfisc opened this issue Sep 15, 2024 · 0 comments · Fixed by #625
Closed

Re-Organize CI Tests #623

s3alfisc opened this issue Sep 15, 2024 · 0 comments · Fixed by #625
Labels
infrastructure Everything Related to Package Infrastructure: Github Actions, pre-commit hooks, poetry, linting, etc

Comments

@s3alfisc
Copy link
Member

s3alfisc commented Sep 15, 2024 •
edited
Loading

CI tests currently run for about one hour, which is way too long.

Some ideas how to reduce testing time:

  1. Add "advanced-tests" that are only run when a comment is placed in the PR. See this DoWhy wfl. For example, we could exclude the plotting / API tests and all tests for summarization from the base CI this way.
  2. Add a workflow with a "nightly build" that runs all CI tests, including the advanced tests. See DoWhy's nightly build.
  3. Potentially, re-evaluate if all tests in test_vs_fixest.py are really needed.
  4. Potentially, the installed environments could be cached?
  5. If only the docs are updated, only rebuild the docs, if only the readme is updated, no tests, etc. EconML has some interesting rules in this regard (link)
@s3alfisc s3alfisc added the infrastructure Everything Related to Package Infrastructure: Github Actions, pre-commit hooks, poetry, linting, etc label Sep 15, 2024
@s3alfisc s3alfisc linked a pull request Sep 16, 2024 that will close this issue
Improve CI Run-Time: Test Smarter #625
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Everything Related to Package Infrastructure: Github Actions, pre-commit hooks, poetry, linting, etc
Projects
Infrastructure
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve CI Run-Time: Test Smarter py-econometrics/pyfixest
1 participant
@s3alfisc