Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bugs in pf.etable() regarding fixed effects information #593

Closed
s3alfisc opened this issue Aug 28, 2024 · 4 comments · Fixed by #594
Closed

Small bugs in pf.etable() regarding fixed effects information #593

s3alfisc opened this issue Aug 28, 2024 · 4 comments · Fixed by #594
Labels
bug Something isn't working

Comments

@s3alfisc
Copy link
Member

When the first estimated model contains a fixed effect, but the second does not, the fixed effect column will render nan instead of -.

Example:

import pyfixest as pf

data = pf.get_data()
fit1 = pf.feols("Y ~ X1 | f1", data = data)
fit2 = pf.feols("Y ~ X1", data = data)

pf.etable([fit1, fit2])

image

Then there is yet another bug!

Printing the models in opposite order, i.e.

pf.etable([fit2, fit1])

all columns below the estimated parameters are not sorted appropriately:
image

fyi @dsliwka (I think all of this might have been around for a while already).

@s3alfisc s3alfisc added the bug Something isn't working label Aug 28, 2024
@s3alfisc
Copy link
Member Author

This does not happen when both models have fixed effects:

import pyfixest as pf

data = pf.get_data()
fit1 = pf.feols("Y ~ X1 | f1", data = data)
fit2 = pf.feols("Y ~ X1 | f2", data = data)

pf.etable([fit1, fit2])

image

@s3alfisc
Copy link
Member Author

Alberto, who has reported the bug, has already suggested a quick fix =)

@dsliwka
Copy link
Contributor

dsliwka commented Aug 28, 2024

@s3alfisc: Has the fix solved both issues? Otherwise I of course will have a look. Sorry!

@s3alfisc
Copy link
Member Author

Hi Dirk, not your fault and I have a fix. No need for you to take a look. Just tagged you as an fyi =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants