-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fepois: Add support for predict
with newdata
argument
#468
Comments
Sounds like a good plan! I agree, it makes sense to only define the |
Yes, happy to take it on! |
This can be close right @leostimpfle ? |
Ah no, actually not. Still throws an error. But in principle we should be able to support it now I think |
Yes, it should work without fixed effects. After your recent bugfix in the calculation of fixed effects, it will hopefully straightforward to support predict with both newdata and fixed effects. I should have some time this weekend to look into it |
Context
Currently, the
newdata
argument is disabled forFepois.predict
. Unfortunately, I do not recall why... 😅To do
newdata
argument for `Fepois.predict().newdata
intests/test_errors.py
.tests/test_vs_r::test_single_fit
.The text was updated successfully, but these errors were encountered: