Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use execFile instead of exec when calling xdg-open script #54

Open
BHSPitMonkey opened this issue May 31, 2016 · 0 comments
Open

Use execFile instead of exec when calling xdg-open script #54

BHSPitMonkey opened this issue May 31, 2016 · 0 comments

Comments

@BHSPitMonkey
Copy link

On Linux, open.js invokes vendor/xdg-open using exec with a command string.

Because xdg-open is a local script included with the module, this causes problems in Electron applications that are packed into an ASAR archive. (ASAR tries to resolve internal paths to files in the application, but doesn't know how to handle an arbitrary command string like the ones used by this module.) This specific pitfall is documented here: http://electron.atom.io/docs/tutorial/application-packaging/#executing-binaries-inside-asar-archive

I understand this isn't the fault of this module, but it nonetheless be very helpful to switch from exec to execFile when calling the local xdg-open script if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant