Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always getting response of twaManifest.shortcuts.map is not a function #7

Closed
ajeetku opened this issue Feb 13, 2020 · 4 comments
Closed

Always getting response of twaManifest.shortcuts.map is not a function #7

ajeetku opened this issue Feb 13, 2020 · 4 comments
Labels
needs triage 🔍

Comments

@ajeetku
Copy link

ajeetku commented Feb 13, 2020

twaManifest.shortcuts.map is not a function
@ghost ghost added the needs triage 🔍 label Feb 13, 2020
@ghost
Copy link

ghost commented Feb 13, 2020

Hello ajeetku, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

@andreban
Copy link
Contributor

I suspect this is related to this llama-pack change: GoogleChromeLabs/bubblewrap#99

twaManifest.shortcuts used to be of type string, but has been replaced with ShortcutInfo[], to make it more structured and safer to use across the code.

@TesheG TesheG mentioned this issue Mar 19, 2020
Closed
@JudahGabriel
Copy link
Collaborator

We'll have a fix for this shortly as we migrate from llama-pack to bubblewrap.

@JudahGabriel
Copy link
Collaborator

This has been fixed from the CloudAPK side for awhile. However, PWABuilder website still would pass a string here. This has been fixed here.

@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs triage 🔍
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JudahGabriel @andreban @ajeetku