Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs build fail: sphinx configuration file is missing #2357

Closed
RDaxini opened this issue Jan 14, 2025 · 3 comments · Fixed by #2358
Closed

Docs build fail: sphinx configuration file is missing #2357

RDaxini opened this issue Jan 14, 2025 · 3 comments · Fixed by #2358
Labels
bug build tools Pipelines, CI, GH actions
Milestone

Comments

@RDaxini
Copy link
Contributor

RDaxini commented Jan 14, 2025

Describe the bug
Docs aren't building on PRs

To Reproduce
Steps to reproduce the behavior:

  1. Go to [WIP] Add spectral mismatch model comparison table #2353 (an example)
  2. Go to docs build details

Expected behavior
Docs should build. Configuration key required in .readthedocs.yaml

Versions:

  • pvlib.__version__: 0.11.2

Additional context
Further information in this blog post

@RDaxini RDaxini added this to the v0.11.3 milestone Jan 14, 2025
@RDaxini RDaxini added the build tools Pipelines, CI, GH actions label Jan 14, 2025
@RDaxini RDaxini added the bug label Jan 14, 2025
@cwhanse
Copy link
Member

cwhanse commented Jan 14, 2025

#2352 builds. Is the failure only for draft (WIP) PRs? What happens if #2353 is changed from Draft?

@RDaxini
Copy link
Contributor Author

RDaxini commented Jan 14, 2025

@cwhanse I think #2352 builds because the last commit was 4 days ago, whereas builds were only disallowed as of yesterday (13th)
I've converted #2353 from draft to double check as suggested though; Are you able initiate a re-run of tests or do I need to commit something?

@cwhanse
Copy link
Member

cwhanse commented Jan 14, 2025

The tests re-ran when the PR was converted, and the docs build fails. That answers my question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build tools Pipelines, CI, GH actions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants