Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_extra_radiation references could use an update #2333

Open
kandersolar opened this issue Dec 16, 2024 · 1 comment
Open

get_extra_radiation references could use an update #2333

kandersolar opened this issue Dec 16, 2024 · 1 comment

Comments

@kandersolar
Copy link
Member

get_extra_radiation has five references:

References
----------
.. [1] M. Reno, C. Hansen, and J. Stein, "Global Horizontal Irradiance
Clear Sky Models: Implementation and Analysis", Sandia National
Laboratories, SAND2012-2389, 2012.
.. [2] http://solardata.uoregon.edu/SolarRadiationBasics.html, Eqs.
SR1 and SR2
.. [3] Partridge, G. W. and Platt, C. M. R. 1976. Radiative Processes
in Meteorology and Climatology.
.. [4] Duffie, J. A. and Beckman, W. A. 1991. Solar Engineering of
Thermal Processes, 2nd edn. J. Wiley and Sons, New York.
.. [5] ASCE, 2005. The ASCE Standardized Reference Evapotranspiration
Equation, Environmental and Water Resources Institute of the American
Civil Engineers, Ed. R. G. Allen et al.

There are a few issues:

  • Ref 2 seems to not exist anymore. Here's an archive.org backup: https://web.archive.org/web/20240424224453/http://solardata.uoregon.edu/SolarRadiationBasics.html
  • I am guessing the following reference should probably be added for method='spencer': J. W. Spencer, "Fourier series representation of the position of the sun" in Search 2 (5), p. 172 (1971)
  • Duffie & Beckman could also be a relevant reference for method='spencer', but I don't think the 2nd edition (i.e., the cited edition) actually has it. I believe some later editions do.
@leliadeville
Copy link

The page for pvlib.atmosphere.get_relative_airmass specifies which citation corresponds to which specific model choice. It would be a nice addition when updating the references here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants