Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update French translation #493

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Update French translation #493

merged 2 commits into from
Sep 1, 2024

Conversation

scandella
Copy link
Contributor

No description provided.

bencroker
bencroker requested changes Sep 1, 2024
View reviewed changes
Copy link
Collaborator

@bencroker bencroker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments about your changes, please address them and I’ll take another look.

src/translations/fr/campaign.php Outdated Show resolved Hide resolved
src/translations/fr/campaign.php Outdated Show resolved Hide resolved
@bencroker bencroker merged commit 2ede2bb into putyourlightson:develop Sep 1, 2024
2 checks passed
@bencroker
Copy link
Collaborator

Thank you!

bencroker added a commit that referenced this pull request Sep 1, 2024
@bencroker
Update French translation (#493)
9cfbd86
@bencroker
Copy link
Collaborator

bencroker commented Sep 19, 2024 •
edited
Loading

Released in 3.5.0.

@scandella
Copy link
Contributor Author

Hi Ben,
Can we get the translation improvement in Craft 4 too (for V2)?

@bencroker
Copy link
Collaborator

Just released in 2.17.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencroker bencroker bencroker requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scandella @bencroker