Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PusherOptions.readVersionFromProperties android.os.strictmode.DiskReadViolation #288

Open
wbervoets opened this issue Sep 24, 2020 · 2 comments · May be fixed by #349
Open

PusherOptions.readVersionFromProperties android.os.strictmode.DiskReadViolation #288

wbervoets opened this issue Sep 24, 2020 · 2 comments · May be fixed by #349
Labels
feature-request hacktoberfest

Comments

@wbervoets
Copy link

What is the issue?

When enabling StrictMode on Android the PusherOptions.readVersionFromProperties generates a DiskReadViolation because it reads from the file system from the UI thread.

Isn't it possible to let the build system generate a BuildConfig.PUSHER_VERSION file that is used instead so we don't need to read in the file when constructing PusherOptions() ?

...

CC @pusher/mobile
@daniel-shuy daniel-shuy linked a pull request Oct 29, 2022 that will close this issue
Open
@daniel-shuy
Copy link

Created a PR (#349) which should fix this

@wbervoets
Copy link
Author

any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use BuildConfig instead of reading version from properties file daniel-shuy/pusher-websocket-java
4 participants
@danielrbrowne @wbervoets @daniel-shuy @britneycodes