-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodule from v1.6.7 to v2.0.0 #62
Comments
It's currently pointed at master, which has the same code as v2.0.0 (the only patch it doesn't have that the v2.0.0 tg has is a change to the cmake build script, which we no longer use). |
Are you sure? It looks like v2.0.0 comes from the dev-slice branch which is 200 commits ahead of Master |
@errantmind appears to be correct: The currect cc build script also only works for master and dev while dev-slice, which is being referred to here as V2, does not. I think it would be better to use feature flags for development branches though rather than use dev over the stable release. |
mimalloc 2.0.0 is now stable. We can just upgrade the dependency rather than make a feature. |
It looks like the submodule is pointed at 2.0.6 already. |
My bad, didn't see that. Can we close this issue and the related PRs, in that case? |
Hey, I'm on mobile right now so my ability to look into this is limited.. but it looks like the submodule is pointed at master which is not the 2.0 (dev-slice) branch upstream. Can anyone verify? |
The sub-module currently links to https://github.com/microsoft/mimalloc/tree/f2712f4a8f038a7fb4df2790f4c3b7e3ed9e219b which is the exact same hash as the tag Though, i still think that it could be useful for some to be able to switch between versions if they need to. Since there arn't that much differences between the two, and it keeps working, it could be useful for some to be able to switch between v1 and v2 if they want/need to. But also use the latest version of either the |
Hello, thanks for maintaining these bindings. I was wondering if you can update your submodule of mimalloc from v1.6.7 to v2.0.0 to take advantage of the improvements.
The text was updated successfully, but these errors were encountered: