Skip to content
This repository has been archived by the owner on Oct 4, 2020. It is now read-only.

eventListener missing eff? #12

Closed
nwolverson opened this issue Aug 21, 2015 · 2 comments
Closed

eventListener missing eff? #12

nwolverson opened this issue Aug 21, 2015 · 2 comments

Comments

@nwolverson
Copy link
Contributor

This type seems suspicious to me:

eventListener :: forall eff a. (Event -> Eff (dom :: DOM) a) -> EventListener eff

is that missing an | eff? If the handler itself isn't allowed to do eff I don't see that you'd have put it in the type.

@garyb
Copy link
Member

garyb commented Aug 21, 2015

Yep, it should have the eff. I think in fact it should be:

eventListener :: forall eff a. (Event -> Eff (dom :: DOM | eff) a) -> EventListener (dom :: DOM | eff)

@garyb
Copy link
Member

garyb commented Aug 21, 2015

(To prevent errors with duplicate rows)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants