-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timezone in milliseconds #27
Comments
I don't think we need a dedicated function for it since it's just |
You will still have minute resolution (multiples of
|
Do you know of a timezone offset that is not a multiple of 15 minutes? I can't imagine milliseconds precision is actually needed? |
There is an example in the comments of the code of the first link. |
Ah I see... man I hate time 😆. I'm still not sure if we need it, since you can only get the timezone offset for the current locale at the current time, which wouldn't fall foul of that. We don't generally deal with timezones at all, I'm not saying we can't add this, just not sure how much value it would have in this library, perhaps would be more useful in If we do add it here we may as well update |
I'm also not aware of a 2023 timezone with sub-minute resolution. But that's because i can't be bothered to look into
It's necessary when you want to print the datetime to the user in their local time.
It shouldn't be a function taking an argument but rather comparing to a freshly constructed
I also find it a bit questionable, but i don't really see a downside to it either. I just thought it was cool that other libraries pick up on the higher resolution that the browser provides. |
Would it be ok to add a function to get the timezone in milliseconds? Because
DateTime
is also milliseconds based so why shouldn't the timezone.https://github.com/date-fns/date-fns/blob/16c529508a323d78f70b91209ebf043f3c09671d/src/_lib/getTimezoneOffsetInMilliseconds/index.ts#L12
The text was updated successfully, but these errors were encountered: