From 7f9e362b4f03f6f86627b5682b0204cec8813685 Mon Sep 17 00:00:00 2001
From: Arun Raghavan <arun@accosted.net>
Date: Thu, 15 Aug 2019 02:41:13 +0000
Subject: [PATCH] Try to recover from effectful code that is annotated as pure
 (#173)

This puts a try-catch around the bind step in order to try to catch code
that is not expected to have effects but does (by throwing).

While this is clearly a programming error, it is certainly not
implausible that effects creep into FFI code inadvertently for Aff
users. This allows us to be defensive in that case and recover, rather
than have all asynchronous options quitely not work after.

The addition of the try-catch does not seem to have a performance impact
(tested on Node v10.15.3). With and without this change, `pulp test`
takes ~4.8s to run.

There is a discussion around this on #172.
---
 src/Effect/Aff.js | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/Effect/Aff.js b/src/Effect/Aff.js
index 190216e..a44656e 100644
--- a/src/Effect/Aff.js
+++ b/src/Effect/Aff.js
@@ -274,12 +274,18 @@ var Aff = function () {
         switch (status) {
         case STEP_BIND:
           status = CONTINUE;
-          step   = bhead(step);
-          if (btail === null) {
-            bhead = null;
-          } else {
-            bhead = btail._1;
-            btail = btail._2;
+          try {
+            step   = bhead(step);
+            if (btail === null) {
+              bhead = null;
+            } else {
+              bhead = btail._1;
+              btail = btail._2;
+            }
+          } catch (e) {
+            status = RETURN;
+            fail   = util.left(e);
+            step   = null;
           }
           break;