Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all instances of "Left" vs "Right" to "Prefix" and "Suffix" #81

Open
1 task
codymullins opened this issue Jun 19, 2024 · 1 comment
Open
1 task

Update all instances of "Left" vs "Right" to "Prefix" and "Suffix" #81

codymullins opened this issue Jun 19, 2024 · 1 comment
Assignees
@ModernMAK
Labels
bug Something isn't working rtl-support

Comments

@codymullins
Copy link
Contributor

codymullins commented Jun 19, 2024 •
edited
Loading

We need to support both LTR and RTL languages. Update references to "Left" and "Right to "Start" and "End".

Components

  • PureButton LeftIcon and RightIcon
@codymullins codymullins added the bug Something isn't working label Jun 19, 2024
@dodyg
Copy link

dodyg commented Jun 19, 2024

https://getbootstrap.com/docs/5.3/utilities/spacing/

Bootstrap uses start and end monikers. They work well.

@codymullins codymullins added dependencies Pull requests that update a dependency file rtl-support and removed dependencies Pull requests that update a dependency file labels Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ModernMAK ModernMAK

Labels
bug Something isn't working rtl-support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codymullins @dodyg @ModernMAK