Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ADI Initialization sequences to decrement/increment smart/adi ports consistently #440

Closed
WillXuCodes opened this issue Oct 10, 2022 · 1 comment
Closed

Fix ADI Initialization sequences to decrement/increment smart/adi ports consistently #440

WillXuCodes opened this issue Oct 10, 2022 · 1 comment

Comments

@WillXuCodes
Copy link
Member

Expected Behavior:

Currently, ADI smart port being 0 or 1 indexed is inconsistent in the API internally... this is not really a breaking change but it's currently tedious for maintenance purposes. I think we should make them all 1 indexed externally, and internally decrement them on port claim and release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Siddhant-Lamichhane @WillXuCodes @Richard-Stump