Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 LLEMU initialization code removed in #152 #164

Closed
HotelCalifornia opened this issue Aug 31, 2019 · 2 comments · Fixed by #165
Closed

🐛 LLEMU initialization code removed in #152 #164

HotelCalifornia opened this issue Aug 31, 2019 · 2 comments · Fixed by #165
Labels
bug Something isn't working p: high High priority todo This will be worked on next
Milestone

Comments

@HotelCalifornia
Copy link
Contributor

Expected Behavior:

LLEMU initialization code should be present in initialize()

Actual Behavior:

It was accidentally removed in #152

@HotelCalifornia HotelCalifornia added p: high High priority bug Something isn't working todo This will be worked on next labels Aug 31, 2019
@HotelCalifornia HotelCalifornia added this to the 3.2.0 milestone Aug 31, 2019
@Octogonapus
Copy link
Contributor

I did not remove this by accident. It seems to do more harm than good, but I won't argue if you want to add it back.

@HotelCalifornia
Copy link
Contributor Author

I did not remove this by accident. It seems to do more harm than good, but I won't argue if you want to add it back.

I'm not sure what harm you mean, but since the code referencing the LCD was not removed from opcontrol, the least we could do is make sure that the default template code actually works as expected out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p: high High priority todo This will be worked on next
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants