Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥🔥🔥🔥🔥🔥🔥🔥⚰️ Goodbye #380

Open
wants to merge 1 commit into
base: develop-cli-4
Choose a base branch
from
Open

🔥🔥🔥🔥🔥🔥🔥🔥⚰️ Goodbye #380

wants to merge 1 commit into from

Conversation

mayankpatibandla
Copy link
Member

@mayankpatibandla mayankpatibandla commented Oct 24, 2024 •
edited by KdotDevelopment
Loading

cli suck

Summary:

See ya

Motivation:

cli sucked

References (optional):

https://github.com/purduesigbots/pros-cli/issues

Test Plan:

  • All files gone

Signees

  • Brandon Liu
  • Mayank Patibandla
  • Rocky Chen
  • Andrew Lu
  • Benjamin Davis (sign by Rocky)
  • Sunay Konnur
  • Naitik Rambhia
  • Ryan Kocourek

@mayankpatibandla
Goodbye
6111426 
cli suck
@mayankpatibandla mayankpatibandla self-assigned this Oct 24, 2024
@BennyBot BennyBot added the p: high High priority label Oct 24, 2024
This was linked to issues Oct 24, 2024
🐛 A few related issues in upload commands #245
Open
🐛Port Detection Isses #248
Open
🐛CLI Hangs on error in terminal #304
Open
🐛 Can't connect to bot via controller #305
Open
🐛Packaged zip sometimes uses local python installation #319
Open
🐛Malformed Depot Breaks All CLI Functionality #342
Open
🐛 SSL Verification doesn't use system trust store #371
Open
🐛Template Files not Included #372
Open
🐛Header-Only Templates Include Empty Binary #373
Open
@Jackman3323 Jackman3323 self-requested a review October 24, 2024 23:58
Jackman3323
Jackman3323 approved these changes Oct 25, 2024
View reviewed changes
Copy link

@Jackman3323 Jackman3323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT MUST BE DONE

Rocky14683
Rocky14683 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@Rocky14683 Rocky14683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✅️

12944qwerty
12944qwerty approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@12944qwerty 12944qwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elmo burn

@Rocky14683 Rocky14683 added the enhancement This builds on top of an existing feature label Oct 25, 2024
@Rocky14683 Rocky14683 reopened this Oct 25, 2024
@ion098
Copy link

ion098 commented Nov 20, 2024

image
@Tropix126 can confirm

@SizzinSeal
Copy link
Contributor

is this just a joke or are y'all actually gonna do this

@djava
Copy link

djava commented Nov 24, 2024

Any details on plans for the new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rocky14683 Rocky14683 Rocky14683 approved these changes

@12944qwerty 12944qwerty 12944qwerty approved these changes

@Jackman3323 Jackman3323 Jackman3323 approved these changes

Assignees

@mayankpatibandla mayankpatibandla

Labels
enhancement This builds on top of an existing feature p: high High priority
Projects
None yet
Milestone
No milestone
9 participants
@mayankpatibandla @ion098 @SizzinSeal @djava @Jackman3323 @12944qwerty @Rocky14683 @BennyBot @WillXuCodes