(bug) - Fixes missing mandatory ID #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
maint-update_dsc_provider
branch
from
a4d5d67
to
abfc23e
Compare
jordanbreen28
force-pushed
the
maint-update_dsc_provider
branch
from
abfc23e
to
fa75d6c
Compare
GSPatton
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a continuation of #204 by https://github.com/Hvid & https://github.com/ShawnHardwick.
Fixes #203 and puppetlabs/Puppet.Dsc#242
This is just copied from the comment by https://github.com/ShawnHardwick
Checklist
We can say with confidence that this change should not break existing DSC functionality thanks to tests added from these issues:
#163
#164
#165
These tests thoroughly test changes to the dsc base provider against published dsc modules.