Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-6738) Update zfs with relatime support #84

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

AriaXLi
Copy link
Contributor

@AriaXLi AriaXLi commented Jul 12, 2024

Originally commited in #79 but had caused some issues in CI. With my additional changes, this no longer causes issues.

(cherry picked from commit 8d19c0f)

Co-authored-by: Jeffrey Clark <[email protected]>
@AriaXLi AriaXLi requested a review from a team as a code owner July 12, 2024 19:03
@AriaXLi AriaXLi added the enhancement New feature or request label Jul 12, 2024
@AriaXLi
Copy link
Contributor Author

AriaXLi commented Jul 15, 2024

Passed with adhoc zfs_core 7.x: https://jenkins-platform.delivery.puppetlabs.net/view/modules/view/Core/view/zfs_core/view/adhoc/job/forge-module_puppetlabs-zfs_core_intn-sys_nightly-puppet_agent_7.x-module_adhoc/14

Passed with adhoc zfs_core main: https://jenkins-platform.delivery.puppetlabs.net/job/forge-module_puppetlabs-zfs_core_intn-sys_nightly-puppet_agent_main-module_adhoc/16/

Before, an invalid property error would pop up:

11:33:11 softest-geology.delivery.puppetlabs.net (solaris114-64-1) 18:33:11$ puppet resource zfs tstpool/tstfs
11:33:11   Error: Could not run: Execution of '/usr/sbin/zfs get -H -o value relatime tstpool/tstfs' returned 2: bad property list: invalid property 'relatime'
11:33:13   For more info, run: zfs help get

After:

1:49:36 over-objective.delivery.puppetlabs.net (solaris114-64-1) 18:49:36$ puppet resource zfs tstpool/tstfs
11:49:36   zfs { 'tstpool/tstfs':
11:49:38     ensure           => 'present',
...
11:49:38     relatime         => '-',
...

@mhashizume mhashizume merged commit 0f74595 into puppetlabs:main Jul 15, 2024
14 checks passed
@AriaXLi AriaXLi changed the title Update zfs with relatime support (PA-6738) Update zfs with relatime support Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants