Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10874) Add property 'sync' #43

Merged
merged 1 commit into from
Dec 11, 2020
Merged

(MODULES-10874) Add property 'sync' #43

merged 1 commit into from
Dec 11, 2020

Conversation

jameslikeslinux
Copy link
Contributor

This property controls how transactions are synchronized and it has been available since Solaris 10 8/11 release:

https://docs.oracle.com/cd/E26505_01/html/E37384/gbscy.html#gjzl

@jameslikeslinux jameslikeslinux requested a review from a team November 20, 2020 18:13
@puppet-community-rangefinder
Copy link

zfs is a type

Breaking changes to this file MAY impact these 4 modules (near match):

This module is declared in 1 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Contributor

@GabrielNagy GabrielNagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iamjamestl,

Thanks for the contribution, the code looks good! Can you also add the new property to the list at https://github.com/puppetlabs/puppetlabs-zfs_core/blob/main/spec/unit/type/zfs_spec.rb#L4

Otherwise this should be good to merge.

This property controls how transactions are synchronized and it has been
available since Solaris 10 8/11 release:

https://docs.oracle.com/cd/E26505_01/html/E37384/gbscy.html#gjzl
@jameslikeslinux
Copy link
Contributor Author

@GabrielNagy, thank you. I've made the change you requested.

@GabrielNagy GabrielNagy merged commit 1f84274 into puppetlabs:main Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants