(MODULES-8823) Add support for overlay option in zfs on Linux #22
Conversation
This option allows mounting over non empty directories. The current
master of zfs_core simply doesn't implement such option on the zfs
resource. This change allows for specification of such option in
puppet modules:
zfs { 'my_pool/my_volume':
ensure => present,
mountpoint => '/mnt/non_empty_dir',
overlay => 'on'
}
|
|
GabrielNagy
added
maintenance
| newproperty(:overlay) do | ||
| desc 'The overlay property. Valid values are `on`, `off`.' | ||
| end | ||
| end |
There was a problem hiding this comment.
This code is unfortunately executed on the server during compilation and the agent during catalog application. So this unfortunately means you can only set this property if the puppetserver is also running on Linux. I think you'd be better off always defining the overlay property, and then add a validate method within the overlay property to fail if the agent kernel is not Linux:
newproperty(:overlay) do
desc ...
validate do |value|
if Facter.value(:kernel) != 'Linux'
fail("The overlay property is unsupported")
end
end
endThere was a problem hiding this comment.
@joshcooper isn't puppetserver only available on Linux platforms though?
There was a problem hiding this comment.
I tried at first with your suggestion, but due to the way the properties are treated in the provider it still gets executed on Solaris... oh well
There was a problem hiding this comment.
We provide puppetserver packages for linux variants, but you can run puppetserver from any POSIX server provided you have Java.
It seems like the zfs module already handles "conditional" properties. Probably should add overlay to
There was a problem hiding this comment.
Thanks, I'll give that a try on Monday.
Fixed up @kali-hernandez's commit by only adding this parameter if we're running on Linux.
Adds back #20