-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 2.6 #8
Conversation
RabbitMQ changed the way list_user behaved between the 2.4.x and 2.5 releases. This updates the code to look for a user that's tagged with `administrator`, the new way that RabbitMQ handles admin users.
RabbitMQ 2.5 changed the way user's are made an admin user. Now, rather than calling `set_admin <user>`, you call `set_user_tags <user> administrator`.
I've thought about abstracting out the |
How about, adding the support for work queues configuration on RabbitMq in coming versions? |
I'm not opposed, but I think that's probably worth a separate PR since this currently is a fix instead of a feature. |
I Agree!! |
Is there any interest in keeping backwards compatibility with previous versions? |
what version are you looking for support for? I was going to create branches with version names so that multiple versions can be maintained in multiple branches. |
I have some installs on 2.2 because that is what's in EPEL. Would it be better to just switch behaviour/features based on a version Fact? |
Slight issue with this pull, its possible for other values to appear in the list_users (on RabbitMQ 2.6.1) output than just administrator or none:
Fixing the match line in the admin check to the following resolves the issue but i'm not sure if its the best method to be using here line.match(/^#{resource[:name]}\s+\[(administrator|.*)?\]/) |
RabbitMQ decided that a minor version bump was time to break
rabbitmqctl
. :-( I've tested this against RabbitMQ 2.6. It obviously doesn't work against < 2.6.Edit: The break was in RabbitMQ 2.6.