Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 2.6 #8

Merged
merged 3 commits into from
Oct 24, 2011
Merged

Upgrade to 2.6 #8

merged 3 commits into from
Oct 24, 2011

Conversation

tswicegood
Copy link
Contributor

RabbitMQ decided that a minor version bump was time to break rabbitmqctl. :-( I've tested this against RabbitMQ 2.6. It obviously doesn't work against < 2.6.

Edit: The break was in RabbitMQ 2.6.

RabbitMQ changed the way list_user behaved between the 2.4.x and 2.5
releases.  This updates the code to look for a user that's tagged with
`administrator`, the new way that RabbitMQ handles admin users.
RabbitMQ 2.5 changed the way user's are made an admin user.  Now, rather
than calling `set_admin <user>`, you call `set_user_tags <user>
administrator`.
@tswicegood
Copy link
Contributor Author

I've thought about abstracting out the rabbitmqctl code as well so you can specify a version if you want to run the old version for some specific reason. Thoughts?

@rajesh-kumar
Copy link

How about, adding the support for work queues configuration on RabbitMq in coming versions?

@tswicegood
Copy link
Contributor Author

I'm not opposed, but I think that's probably worth a separate PR since this currently is a fix instead of a feature.

@rajesh-kumar
Copy link

I Agree!!

bodepd pushed a commit that referenced this pull request Oct 24, 2011
@bodepd bodepd merged commit 0bd6838 into voxpupuli:master Oct 24, 2011
@dcarley
Copy link

dcarley commented Dec 7, 2011

Is there any interest in keeping backwards compatibility with previous versions?

@bodepd
Copy link
Contributor

bodepd commented Dec 7, 2011

what version are you looking for support for?

I was going to create branches with version names so that multiple versions can be maintained in multiple branches.

@dcarley
Copy link

dcarley commented Dec 7, 2011

I have some installs on 2.2 because that is what's in EPEL.

Would it be better to just switch behaviour/features based on a version Fact?

@nikdoof
Copy link

nikdoof commented Jan 6, 2012

Slight issue with this pull, its possible for other values to appear in the list_users (on RabbitMQ 2.6.1) output than just administrator or none:

amqp:~# rabbitmqctl  list_users
Listing users ...
dreddit [management]
processadmin [administrator]
intelapi        [management]
...done.

Fixing the match line in the admin check to the following resolves the issue but i'm not sure if its the best method to be using here

line.match(/^#{resource[:name]}\s+\[(administrator|.*)?\]/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants