diff --git a/.fixtures.yml b/.fixtures.yml index 4815848b..2bc678a5 100644 --- a/.fixtures.yml +++ b/.fixtures.yml @@ -14,9 +14,7 @@ fixtures: augeas_core: 'https://github.com/puppetlabs/puppetlabs-augeas_core.git' postgresql: 'https://github.com/puppetlabs/puppetlabs-postgresql.git' firewall: 'https://github.com/puppetlabs/puppetlabs-firewall.git' - postgresql: - repo: 'https://github.com/puppetlabs/puppetlabs-postgresql.git' - ref: 'v9.2.0' + postgresql: 'https://github.com/puppetlabs/puppetlabs-postgresql.git' firewall: 'https://github.com/puppetlabs/puppetlabs-firewall.git' symlinks: puppetdb: '#{source_dir}' diff --git a/manifests/params.pp b/manifests/params.pp index 151e2251..2c45b519 100644 --- a/manifests/params.pp +++ b/manifests/params.pp @@ -24,11 +24,7 @@ $manage_pg_repo = false } - if $puppetdb_version in ['latest','present'] or versioncmp($puppetdb_version, '7.0.0') >= 0 { - $postgres_version = '11' - } else { - $postgres_version = '9.6' - } + $postgres_version = '14' $puppetdb_major_version = $puppetdb_version ? { 'latest' => '8', diff --git a/metadata.json b/metadata.json index 5e11758c..c4331077 100644 --- a/metadata.json +++ b/metadata.json @@ -14,7 +14,7 @@ }, { "name": "puppetlabs/postgresql", - "version_requirement": ">= 6.5.0 < 10.0.0" + "version_requirement": ">= 6.5.0 < 11.0.0" }, { "name": "puppetlabs/firewall", diff --git a/spec/acceptance/standalone_spec.rb b/spec/acceptance/standalone_spec.rb index 3c2a31f1..f1b4d25e 100644 --- a/spec/acceptance/standalone_spec.rb +++ b/spec/acceptance/standalone_spec.rb @@ -6,8 +6,7 @@ let(:puppetdb_params) {} let(:puppetdb_master_config_params) {} - # TODO: temporary work-around for EL installs - let(:postgres_version) { "(getvar('facts.os.family') == 'RedHat') ? { true => '12', default => undef }" } + let(:postgres_version) { 'undef' } # default let(:manage_firewall) { "(getvar('facts.os.family') == 'RedHat' and Integer(getvar('facts.os.release.major')) > 7)" } describe 'with defaults' do diff --git a/spec/support/acceptance/shared/puppetdb.rb b/spec/support/acceptance/shared/puppetdb.rb index 20fac66b..e269ea4c 100644 --- a/spec/support/acceptance/shared/puppetdb.rb +++ b/spec/support/acceptance/shared/puppetdb.rb @@ -3,19 +3,7 @@ shared_examples 'puppetdb' do let(:pp) do <<~PP - # FIXME: temporary work-around for EL installs if $facts['os']['family'] == 'RedHat' { - $gpg_key_file = $facts['os']['release']['major'] ? { - '7' => 'PGDG-RPM-GPG-KEY-RHEL7', - default => 'PGDG-RPM-GPG-KEY-RHEL', - } - file { "/etc/pki/rpm-gpg/${gpg_key_file}": - source => "https://download.postgresql.org/pub/repos/yum/keys/${gpg_key_file}", - } - -> Yumrepo <| tag == 'postgresql::repo' |> { - gpgkey => "file:///etc/pki/rpm-gpg/${gpg_key_file}", - } - # Work-around EL systemd in docker bug affecting forked services file_line { 'puppetdb-unit-remove-pidfile': path => '/lib/systemd/system/puppetdb.service', diff --git a/spec/support/unit/shared/database.rb b/spec/support/unit/shared/database.rb index 5be30e9a..23a77553 100644 --- a/spec/support/unit/shared/database.rb +++ b/spec/support/unit/shared/database.rb @@ -220,7 +220,7 @@ end shared_examples 'puppetdb::database::postgresql_ssl_rules' do |error| - let(:defaults) { {} } + let(:defaults) { { postgres_version: '14' } } let(:with) { defined?(args) ? defaults.merge(args) : defaults } if error diff --git a/spec/unit/classes/database/postgresql_spec.rb b/spec/unit/classes/database/postgresql_spec.rb index e1e4e104..1b89b258 100644 --- a/spec/unit/classes/database/postgresql_spec.rb +++ b/spec/unit/classes/database/postgresql_spec.rb @@ -94,7 +94,7 @@ { read_database_username: params[:read_database_username], database_name: params[:database_name], - password_hash: 'md588e898a4bade3fe1c9b96f650ec85900', # TODO: mock properly + password_hash: %r{^(md5|SCRAM)}, # TODO: mock properly database_owner: params[:database_username], } end