Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow -_ in ipset name #1207

Closed
wants to merge 1 commit into from

Conversation

2fa
Copy link
Contributor

@2fa 2fa commented Apr 4, 2024

Summary

Allow setting a - and _ in ipset name

Should fix #1187

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@2fa 2fa requested a review from a team as a code owner April 4, 2024 14:16
@deemon87
Copy link

I really need it. Pls already merge it

@elkangaroo
Copy link

@2fa FYI the "\w" already contains underscores, so as a workaround one can change - with _ in existing ipsets.

This fix would still be great if merged, as it used to work before puppetlabs-firewall 7.0.0 release.

@2fa
Copy link
Contributor Author

2fa commented Sep 10, 2024

@2fa FYI the "\w" already contains underscores, so as a workaround one can change - with _ in existing ipsets.

This fix would still be great if merged, as it used to work before puppetlabs-firewall 7.0.0 release.

Yeah, you are correct about _. I probably was fixing - and thought about to add underscore as a future-proof, but forgot that it's already included in \w.

I know that i can simple rename all ipsets to use underscores, but it worked before so for me it was better to just fix the issue.

Right now we're using the latest 6.X version, 7.0 has too many problems: it's very slow, for example. #1214

@cmusik
Copy link
Contributor

cmusik commented Sep 23, 2024

I have a similar problem but in my case it is a colon that is missing in the regex. If I have checked the ipset source, and there is no limitations besides a length limit. Even spaces are allowed, but this will probably lead to other problems in parsing.

@malikparvez
Copy link
Member

@2fa could you fix the linting errors...

@span786
Copy link
Contributor

span786 commented Oct 21, 2024

We will be adding the changes mentioned in this PR in #1237

@span786 span786 closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyphen in the ipset's hash name breaks a firewall resource
7 participants