Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close method of transports not called #257

Open
DavidS opened this issue Feb 17, 2020 · 0 comments
Open

close method of transports not called #257

DavidS opened this issue Feb 17, 2020 · 0 comments
Labels

Comments

@DavidS
Copy link
Contributor

DavidS commented Feb 17, 2020

Describe the Bug

The close method on a Transport is not called at the end of processing.

Expected Behavior

The close method on a Transport should be called to release a transport's external resources at the end of processing.

Steps to Reproduce

By a community member on slack:

As a test, i added

def close(context)
    context.debug('Logout connection')

However, it doesn't get called. I don't see it in the logs

Additional Context

Any ruby-side resources are usually cleaned up at the end of processing by puppet device or ACE's forked processing. This does not help for resources that a transport allocates outside of ruby (e.g. opening a session on the target API).

@DavidS DavidS added the bug label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant