Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn velocity plot test into a figure test #325

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

svank
Copy link
Contributor

@svank svank commented Nov 25, 2024

PR summary

It's a figure test now

@svank
Copy link
Contributor Author

svank commented Nov 25, 2024

Note that pytest needs to have '--mpl' added to the command line to actually run the comparison. I like to make that happen by default like this

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.15%. Comparing base (f0cfdc1) to head (6d6e246).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
punchbowl/level3/velocity.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   86.97%   86.15%   -0.83%     
==========================================
  Files          56       56              
  Lines        3717     3793      +76     
==========================================
+ Hits         3233     3268      +35     
- Misses        484      525      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes
Copy link
Member

@svank can you look at the CI for this? Thanks!

@svank
Copy link
Contributor Author

svank commented Nov 27, 2024

Looks like this repo doesn't use pytest-arraydiff, so the --arraydiff flag was being rejected. Let's try this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants