Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate new providers #6489

Open
iwahbe opened this issue Jan 23, 2025 · 0 comments
Open

Validate new providers #6489

iwahbe opened this issue Jan 23, 2025 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@iwahbe
Copy link
Member

iwahbe commented Jan 23, 2025

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Before a provider is added to the Pulumi Registry, it needs to have a valid schema and valid docs. We should run a check on changes to community-packages/package-list.json, ensuring that any added package is valid. This could be as simple as invoking resourcedocsgen premptily (not just after the merge):

# We only need to run the following steps if resourcedocsgen found a newer version of the community provider.
- name: Generate Package Metadata
if: env.PROVIDER_VERSION
run: >-
./tools/resourcedocsgen/resourcedocsgen metadata from-github
--repoSlug "${{ matrix.repoSlug }}"
--schemaFile "${{ matrix.schemaFile }}"
--version "${{ env.PROVIDER_VERSION }}"

That would guarantee that the first published version would be correct.

Affected area/feature

This would have prevented #6488.

@iwahbe iwahbe added the kind/enhancement Improvements or new features label Jan 23, 2025
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Jan 23, 2025
@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

3 participants