Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to install from source #89

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Make it possible to install from source #89

merged 1 commit into from
Nov 22, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Nov 22, 2024

The replace directives in go.mod make it impossible to install and run pulumictl from source.

They were originally added as part of #59, however we still seem to cross-compile just fine:

❯ goreleaser build --snapshot --clean
  • starting build...
  • loading config file                              file=.goreleaser.yml
  • loading environment variables
  • getting and validating git state
    • building...                                    commit=eb7f539414133eb4a4a172fe89e211beeeff2a4e latest tag=v0.0.46
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • running before hooks
    • running                                        hook=go mod download
    • took: 27s
  • snapshotting
    • building snapshot...                           version=v0.0.46-SNAPSHOT
  • checking distribution directory
    • cleaning dist
  • loading go mod information
  • build prerequisites
  • writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • building                                       binary=dist/pulumictl_darwin_amd64_v1/pulumictl
    • building                                       binary=dist/pulumictl_windows_amd64_v1/pulumictl.exe
    • building                                       binary=dist/pulumictl_darwin_arm64/pulumictl
    • building                                       binary=dist/pulumictl_linux_arm64/pulumictl
    • building                                       binary=dist/pulumictl_windows_arm64/pulumictl.exe
    • building                                       binary=dist/pulumictl_linux_amd64_v1/pulumictl
    • took: 1m28s
  • storing release metadata
    • writing                                        file=dist/artifacts.json
    • writing                                        file=dist/metadata.json
  • build succeeded after 1m55s
  • thanks for using goreleaser!

@blampe blampe requested review from t0yv0 and a team November 22, 2024 01:05
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely remember that this was because pulumi/pulumi linked in some CGO stuff for file watching.

It should be safe to remove.

@blampe blampe merged commit cbb56e4 into master Nov 22, 2024
3 checks passed
@blampe blampe deleted the blampe/notify branch November 22, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants