Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upstream path #491

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Update upstream path #491

merged 2 commits into from
Nov 1, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 1, 2024

No description provided.

@iwahbe iwahbe requested a review from danielrbradley November 1, 2024 12:51
@iwahbe iwahbe self-assigned this Nov 1, 2024
@iwahbe iwahbe mentioned this pull request Nov 1, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

danielrbradley
danielrbradley approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab thanks 👍

@danielrbradley
Copy link
Member

Looks like a minor lint issue:

provider/resources.go:24: File is not `gci`-ed with --skip-generated -s standard -s blank -s default -s prefix(github.com/pulumi/) -s prefix(github.com/pulumi/pulumi-xyz) --custom-order (gci)
  	// Replace this provider with the provider you are bridging.
  	xyz "github.com/pulumi/terraform-provider-xyz/provider"
  
  provider/resources.go:30: File is not `gci`-ed with --skip-generated -s standard -s blank -s default -s prefix(github.com/pulumi/) -s prefix(github.com/pulumi/pulumi-xyz) --custom-order (gci)
  	"github.com/pulumi/pulumi/pkg/v3/codegen/schema"

@danielrbradley danielrbradley merged commit 3c8b641 into main Nov 1, 2024
23 checks passed
@iwahbe iwahbe deleted the iwahbe/update-upstream-path branch November 1, 2024 15:55
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v1.1.32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrbradley danielrbradley danielrbradley approved these changes

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwahbe @danielrbradley @pulumi-bot