Detailed diff tests for block types #2398
Conversation
VenelinMartinov
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2398 +/- ##
=======================================
Coverage 57.66% 57.66%
=======================================
Files 369 369
Lines 50148 50148
=======================================
+ Hits 28917 28918 +1
Misses 19652 19652
+ Partials 1579 1578 -1 ☔ View full report in Codecov by Sentry. |
pkg/tests/schema_pulumi_test.go
Outdated
| `), | ||
| false, | ||
| }, | ||
| // TODO: where is the nested prop diff coming from |
There was a problem hiding this comment.
TODO: replace with links to the relevant issues.
|
Add these issues to the epic please. |
| map[string]interface{}{"setProps": []interface{}{"val2", "val3"}}, | ||
| map[string]interface{}{"setProps": []interface{}{"val1", "val2", "val3"}}, | ||
| autogold.Expect(`Previewing update (test): | ||
| pulumi:pulumi:Stack: (same) |
There was a problem hiding this comment.
Nice, autogodl expect actual Pulumi output is highly trustworthy
There was a problem hiding this comment.
Given that the contract for the detailed diff response between the engine and the provider is not very trustworthy, this seems like the best thing we can do.
|
Feel free to check in when CI allows. Skip tests that do not pass yet. |
|
This PR has been shipped in release v3.91.0. |
This adds tests for the detailed diff output of
for adding, removing, changing the property and adding, removing, changing nested properties in the block.
A few issues here:
__defaultsproperty when the number of elements in the block changes.