Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross tests for PF inputs #2244

Open
VenelinMartinov opened this issue Jul 24, 2024 · 1 comment
Open

Cross tests for PF inputs #2244

VenelinMartinov opened this issue Jul 24, 2024 · 1 comment
Labels
kind/engineering Work that is not visible to an external user

Comments

@VenelinMartinov
Copy link
Contributor

What happened?

#2218 found a discrepancy in the way we transform properties from TF plan and pass into the TF apply.

Would be nice to get some cross-tests going on the PF side to catch any other such issues.

Example

We have such tests for the SDKv2:

func TestInputsEqualStringBasic(t *testing.T) {

It should be possible to do the same on the PF side.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added the kind/engineering Work that is not visible to an external user label Jul 24, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Jul 24, 2024
@guineveresaenger guineveresaenger removed the needs-triage Needs attention from the triage team label Jul 24, 2024
@VenelinMartinov
Copy link
Contributor Author

The pulumi side of this was done in #2186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

3 participants