Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deconflict ExactlyOneOf violations in Read #1949

Open
t0yv0 opened this issue May 9, 2024 · 2 comments
Open

Deconflict ExactlyOneOf violations in Read #1949

t0yv0 opened this issue May 9, 2024 · 2 comments
Labels
kind/enhancement Improvements or new features

Comments

@t0yv0
Copy link
Member

t0yv0 commented May 9, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Placeholder to deconflict ExactlyOneOf violations similar to how ConflictsWith violations are handled when processing Read results to make sure Read produces validation-clean results.

Affected area/feature
@t0yv0 t0yv0 added needs-triage Needs attention from the triage team kind/enhancement Improvements or new features labels May 9, 2024
@VenelinMartinov
Copy link
Contributor

The hypothesis is that this happens for tf resource properties with ExactlyOneOf + Computed or ExactlyOneOf + Default

@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label May 10, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented May 20, 2024

Linking #1948 where we introduced a heuristic for deconflicting ConflictsWith during import

This was referenced May 20, 2024
Open
Closed
@VenelinMartinov VenelinMartinov mentioned this issue May 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t0yv0 @VenelinMartinov